Update Go modules #382
Update Go modules #382
Conversation
SuperQ
force-pushed
the
superq/update_go
branch
5 times, most recently
from
051ced2 to
681bc8e
Compare
SuperQ
requested review from
metalmatze,
prombot and
roidelapluie
and removed request for
prombot
|
I am against the move to yamlv3 because we can't move prometheus at this moment. |
It doesn't seem to have any API changes. I'm curious what's the reason behind it? Is there something I can check out? |
|
The only major change is that "Strict" loading doesn't work as it did before. |
|
Thanks, can we update minimum version of client_golang first? |
|
I think we need to have a client_golang release and then I can bump the dependency here. |
@SuperQ client_golang released https://github.com/prometheus/client_golang/releases/tag/v1.13.0 |
SuperQ
force-pushed
the
superq/update_go
branch
from
58b2519 to
ca63b5a
Compare
kakkoyun
left a comment
kakkoyun
left a comment
There was a problem hiding this comment.
Only have a question about the workflow file otherwise LGTM
| uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: 1.17.x | ||
| go-version: 1.18.x |
There was a problem hiding this comment.
If I'm not mistaken, this file synced from Prometheus's main repo.
We might need to change it in there, no?
https://github.com/prometheus/prometheus/blob/main/scripts/sync_repo_files.sh
There was a problem hiding this comment.
This is actually doing the sync from upstream, since we need some of the other updates in this PR to make it pass CI.
There was a problem hiding this comment.
#379 was the last prombot sync, couldn't pass CI.
* Update Go testing to 1.18. * Update Go minimum version to 1.17. * Update Go module format for 1.17. * Bump Go modules. Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/update_go
branch
from
ca63b5a to
9d646db
Compare
Signed-off-by: SuperQ superq@gmail.com