Skip to content

Compact types.MethodType between 2 and 3 #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Compact types.MethodType between 2 and 3 #403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion prometheus_client/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@

if sys.version_info > (3,):
unicode = str
create_bound_method = types.MethodType
else:
def create_bound_method(func, obj):
return types.MethodType(func, obj, obj.__class__)


def _build_full_name(metric_type, name, namespace, subsystem, unit):
Expand Down Expand Up @@ -369,7 +373,7 @@ def set_function(self, f):
def samples(self):
return (('', {}, float(f())),)

self._child_samples = types.MethodType(samples, self)
self._child_samples = create_bound_method(samples, self)

def _child_samples(self):
return (('', {}, self._value.get()),)
Expand Down