Skip to content

Fix UnknownDataPointSnapshot constructor #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhoard merged 1 commit into from
Jul 30, 2024
Merged

Fix UnknownDataPointSnapshot constructor #977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...us-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/UnknownSnapshot.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public static final class UnknownDataPointSnapshot extends DataPointSnapshot {
* @param exemplar may be null.
*/
public UnknownDataPointSnapshot(double value, Labels labels, Exemplar exemplar) {
this(value, Labels.EMPTY, exemplar, 0);
this(value, labels, exemplar, 0);
}

/**
Expand Down
16 changes: 16 additions & 0 deletions ...etrics-model/src/test/java/io/prometheus/metrics/model/snapshots/UnknownSnapshotTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,20 @@ public void testNameMissing() {
public void testValueMissing() {
UnknownSnapshot.UnknownDataPointSnapshot.builder().build();
}

@Test
public void testUnknownDataPointSnapshot() {
Labels labels = Labels.of("k1", "v1");
Exemplar exemplar = Exemplar.builder().value(2.0).build();

UnknownSnapshot.UnknownDataPointSnapshot data = new UnknownSnapshot.UnknownDataPointSnapshot(1.0, labels, exemplar);
Assert.assertEquals(1.0, data.getValue(), 0.1);
Assert.assertEquals(labels, data.getLabels());
Assert.assertEquals(exemplar, data.getExemplar());

data = new UnknownSnapshot.UnknownDataPointSnapshot(1.0, labels, exemplar, 0L);
Assert.assertEquals(1.0, data.getValue(), 0.1);
Assert.assertEquals(labels, data.getLabels());
Assert.assertEquals(exemplar, data.getExemplar());
}
}