feat: add bearerToken builder to pushgateway exporter#968
Merged
dhoard merged 3 commits intoprometheus:mainfrom Jul 18, 2024
Merged
feat: add bearerToken builder to pushgateway exporter#968dhoard merged 3 commits intoprometheus:mainfrom
dhoard merged 3 commits intoprometheus:mainfrom
Conversation
Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
Contributor
Author
|
@fstab would you PTAL? 🙏 I initially added also integration tests, but PGW itself does not support the bearer token auth yet so I dropped them since it was testing nothing. |
Contributor
Author
|
Or maybe @dhoard ? |
dhoard
approved these changes
Jul 18, 2024
Contributor
Author
|
Thanks! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add possibility to set bearer token when pushingmetrics to pushgateway
The PGW itself does not support the bearer token auth but it is needed if behind some auth proxy for example