Skip to content

Unit class hardening#897

Merged
fstab merged 1 commit intoprometheus:mainfrom
dhoard:Unit-class-cleanup
Nov 12, 2023
Merged

Unit class hardening#897
fstab merged 1 commit intoprometheus:mainfrom
dhoard:Unit-class-cleanup

Conversation

@dhoard
Copy link
Collaborator

@dhoard dhoard commented Nov 11, 2023

Added equals and hashcode to be able to compare a Unit.
Change code to catch an empty String on construction.
Added JUnit test.

Signed-off-by: dhoard <doug.hoard@gmail.com>
@dhoard dhoard requested a review from fstab November 11, 2023 17:04
@dhoard dhoard changed the title Added equals and hashcode. Changed code to catch an empty String Unit class hardening Nov 11, 2023
Copy link
Member

@fstab fstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dhoard

@fstab fstab merged commit e8b3f87 into prometheus:main Nov 12, 2023
@dhoard dhoard deleted the Unit-class-cleanup branch August 29, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants