Merged
Conversation
Signed-off-by: Guido Anzuoni <ganzuoni@gmail.com>
Signed-off-by: Guido Anzuoni <ganzuoni@gmail.com>
Signed-off-by: Guido Anzuoni <ganzuoni@gmail.com>
fstab
requested changes
Oct 15, 2023
Member
fstab
left a comment
fstab
left a comment
There was a problem hiding this comment.
Hi @ganzuoni, thanks a lot for the PR! I added a few comments, nothing major, mostly refactoring.
BTW while reviewing it I found a few shortcomings in the current implementation and merged #875 and #876. Looks like multi target support is the first time that we look closely at using the Collector interface directly. Thanks a lot for coming up with that use case!
Please rebase to the current main so that you get the latest changes.
...pserver/src/main/java/io/prometheus/metrics/examples/httpserver/SampleExtendedCollector.java
Outdated
Show resolved
Hide resolved
...rter-httpserver/src/main/java/io/prometheus/metrics/examples/httpserver/MainMultiTarget.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/io/prometheus/metrics/examples/httpserver/SampleExtendedMultiCollector.java
Outdated
Show resolved
Hide resolved
...metrics-model/src/main/java/io/prometheus/metrics/model/registry/ExtendedMultiCollector.java
Outdated
Show resolved
Hide resolved
prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/registry/MultiCollector.java
Outdated
Show resolved
Hide resolved
prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/registry/MultiCollector.java
Outdated
Show resolved
Hide resolved
prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/registry/MultiCollector.java
Show resolved
Hide resolved
...eus-metrics-model/src/main/java/io/prometheus/metrics/model/registry/PrometheusRegistry.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Guido Anzuoni <ganzuoni@gmail.com>
Signed-off-by: Guido Anzuoni <ganzuoni@gmail.com>
Signed-off-by: Guido Anzuoni <ganzuoni@gmail.com>
Signed-off-by: Guido Anzuoni <ganzuoni@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting of the same implementation to main branch