Skip to content

[prometheus-metrics-instrumentation-caffeine] implement getPrometheus…#1206

Merged
zeitlinger merged 1 commit intoprometheus:mainfrom
pheyken:caffeine-prometheus-names
Nov 21, 2024
Merged

[prometheus-metrics-instrumentation-caffeine] implement getPrometheus…#1206
zeitlinger merged 1 commit intoprometheus:mainfrom
pheyken:caffeine-prometheus-names

Conversation

@pheyken
Copy link
Contributor

@pheyken pheyken commented Nov 15, 2024

…Names

Hey all, implementing this should have following benefits:

  • registering the CacheCollector twice will fail immediately and not when collecting metrics
  • avoid collecting metrics from the CacheCollector which would be discarded when a filter is passed to the PrometheusRegistry when scraping

…Names

Signed-off-by: Petar Heyken <mail@petar-heyken.de>
@zeitlinger
Copy link
Member

Thanks!

@zeitlinger zeitlinger merged commit 2f30038 into prometheus:main Nov 21, 2024
@pheyken pheyken deleted the caffeine-prometheus-names branch November 21, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants