Revert "ci: daggerize test and lint pipelines (#1534)" #1717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3634bd9. # Conflicts: # .github/workflows/dagger-golangci-lint.yml # .github/workflows/go.yml # dagger.json # dagger/main.go
bwplotka
requested review from
ArthurSens,
kakkoyun and
vesari
as code owners
ArthurSens
approved these changes
Jan 21, 2025
kakkoyun
approved these changes
Jan 21, 2025
This was referenced Feb 19, 2025
Merged
1 task
1 task
1 task
1 task
1 task
1 task
1 task
This was referenced Feb 19, 2025
Merged
1 task
This was referenced Feb 19, 2025
Update module github.com/prometheus/client_golang to v1.21.1 - autoclosed
giantswarm/exporterkit#147
Closed
1 task
This was referenced Apr 9, 2025
This was referenced Apr 13, 2025
Open
1 task
This was referenced Apr 15, 2025
1 task
This was referenced Apr 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With @kakkoyun we decided to stop this experiment and remove dagger. I personally don't see it's usefulness for pure Go library like client_golang and it creates a few unnecessary issues like:
Essentially go tooling is reproducible and portable enough on its own for our needs.
Plus Prometheus org has shared GH actions that benefits from the consistency (e.g. same linting).
This reverts commit 3634bd9.