fix: omit empty text field in Mattermost notifications#4985
Open
slashpai wants to merge 1 commit intoprometheus:mainfrom
Open
fix: omit empty text field in Mattermost notifications#4985slashpai wants to merge 1 commit intoprometheus:mainfrom
slashpai wants to merge 1 commit intoprometheus:mainfrom
Conversation
Add omitempty tag to Text field to prevent sending empty text values to Mattermost, which causes 400 errors. Per the Mattermost API spec, text is only required if attachments are not set. Related to prometheus-operator/prometheus-operator#8363 Signed-off-by: Jayapriya Pai <janantha@redhat.com>
5 tasks
Contributor
|
LGTM. Although with the default template, the text field is never empty. So one could argue (which I am not) it is working as designed and users must ensure that custom templates in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add omitempty tag to Text field to prevent sending empty text values to Mattermost, which causes 400 errors. Per the Mattermost API spec, text is only required if attachments are not set.
Related to prometheus-operator/prometheus-operator#8363