Don't allow calling QIDs with an empty IDs list #4707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajagopalanand
approved these changes
Nov 11, 2025
siavashs
approved these changes
Nov 11, 2025
SuperQ
reviewed
Nov 12, 2025
TheMeier
approved these changes
Nov 12, 2025
Calling QIDs with an empty list of IDs is meaningless, and the result may be unexpected (at the moment it would return all silences, but one might expect it to never return any). Make it an error. Signed-off-by: Guido Trotter <guido@hudson-trading.com>
Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: Guido Trotter <ultrotter@gmail.com>
ultrotter
force-pushed
the
noemptyquids
branch
from
2f0eab9 to
4bfcd38
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling QIDs with an empty list of IDs is meaningless, and the result may be unexpected (at the moment it would return all silences, but one might expect it to never return any). Make it an error.