Skip to content

Move Query locking back into private query function #4694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SuperQ merged 2 commits into from
Nov 5, 2025
Merged

Move Query locking back into private query function #4694

SuperQ merged 2 commits into from
Nov 5, 2025

Conversation

@ultrotter
Copy link
Contributor

@ultrotter ultrotter commented Nov 5, 2025 

This was changed in b67bde8cf981dd2f5e86cbb7b886074bf24d7a9c because Set
called query, while already holding a lock, but that call was removed in
dbe6312f098f6698c3b82ed736c0c165a0e19f6a and replaced with a simple
len(s.st) call, so locking can move back to the inner function.

Signed-off-by: Guido Trotter <guido@hudson-trading.com>

Guido Trotter added 2 commits November 5, 2025 09:13
Add parallel benchmarks to silence_bench_test
592ba0e 
Add benchmarks about parallel queries, parallel queries in concurrency
with adds, and about running mutes.

Signed-off-by: Guido Trotter <guido@hudson-trading.com>
Move Query locking back into private query function
f201b2a 
This was changed in b67bde8 because Set
called query, while already holding a lock, but that call was removed in
dbe6312 and replaced with a simple
len(s.st) call, so locking can move back to the inner function.

Signed-off-by: Guido Trotter <guido@hudson-trading.com>
@SuperQ SuperQ merged commit 0fa3a27 into prometheus:main Nov 5, 2025
7 checks passed
@SuperQ SuperQ mentioned this pull request Nov 5, 2025
Closed
@ultrotter ultrotter deleted the movequerylock branch November 8, 2025 09:32
@SoloJacobs SoloJacobs mentioned this pull request Nov 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ultrotter @SuperQ