fix(dispatch): remove waiting ag routines #4632
Open
+114
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change significantely reduces the number of sleeping go routines created per aggregation group and waiting for a timer tick. Instead use time.AfterFunc to schedule the next call to flush. Signed-off-by: Siavash Safi <siavash@cloudflare.com>
|
Do you have any profile captured to show before/after effects of this change? |
|
Yes, it would be nice to post a pprof profile and/or metrics to show the results of this change. |
|
Here are some metrics, in both cases I run the same config for Prometheus and Alertmanager which results in 1500 unique alerts and Aggregation Groups: From # HELP alertmanager_dispatcher_aggregation_groups Number of active aggregation groups
# TYPE alertmanager_dispatcher_aggregation_groups gauge
alertmanager_dispatcher_aggregation_groups 1500
# HELP go_goroutines Number of goroutines that currently exist.
# TYPE go_goroutines gauge
go_goroutines 1532From this branch: # HELP alertmanager_dispatcher_aggregation_groups Number of active aggregation groups
# TYPE alertmanager_dispatcher_aggregation_groups gauge
alertmanager_dispatcher_aggregation_groups 1500
# HELP go_goroutines Number of goroutines that currently exist.
# TYPE go_goroutines gauge
go_goroutines 32Looking at From goroutine profile: total 1529
1500 @ 0x100e0e160 0x100dec7cc 0x1016c2480 0x100e16a04
# 0x1016c247f github.com/prometheus/alertmanager/dispatch.(*aggrGroup).run+0x3ff alertmanager/dispatch/dispatch.go:446
...From this branch no (Note that when flush happens we see a lot of go routines still but those are from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change significantely reduces the number of sleeping go routines created per aggregation group and waiting for a timer tick.
Instead use time.AfterFunc to schedule the next call to flush.
Closes #4503