feat: add names to inhibit rules #4628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siavashs
force-pushed
the
feat/add-inhibit-rule-name
branch
from
f5c83fa to
55983d9
Compare
SuperQ
reviewed
Oct 23, 2025
siavashs
force-pushed
the
feat/add-inhibit-rule-name
branch
from
55983d9 to
cf52d50
Compare
- add Name field to config.InhibitRule - add Name field to inhibit.InhibitRule - update docs for inhibit_rule The name will be used in new metrics to be added in a separate change. Signed-off-by: Siavash Safi <siavash@cloudflare.com>
siavashs
force-pushed
the
feat/add-inhibit-rule-name
branch
from
cf52d50 to
615d0f1
Compare
MichaHoffmann
approved these changes
Oct 23, 2025
MichaHoffmann
left a comment
MichaHoffmann
left a comment
There was a problem hiding this comment.
LGTM! Empty name by default makes sense to me too. Especially if we want to use this for metrics eventually.
SuperQ
approved these changes
Oct 23, 2025
SuperQ
approved these changes
Oct 23, 2025
sysadmind
approved these changes
Oct 23, 2025
holger-waschke
pushed a commit
to holger-waschke/alertmanager
that referenced
this pull request
Nov 1, 2025
- add Name field to config.InhibitRule - add Name field to inhibit.InhibitRule - update docs for inhibit_rule The name will be used in new metrics to be added in a separate change. Signed-off-by: Siavash Safi <siavash@cloudflare.com> Signed-off-by: Holger Waschke <holger.waschke@dvag.com>
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name will be used in new metrics to be added in a separate change.