Add templating functions for working with URLs #4625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruben Simons <r.simons@fz-juelich.de>
Signed-off-by: Ruben Simons <r.simons@fz-juelich.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is adding 2 functions to templating to improve ability to work with URLs in templates.
These functions are
safeUrl(the same assafeHtml, but for URLs)urlUnescape(transforming stuff like%20to blanks)For relevant context on why I need that, see #4616. I'm also fine with dropping either of the functions for my issue.
safeUrlmight have some security implications, whileurlUnescapecan already be implemented quite inefficiently with a long chain ofreReplaceAlland therefore should have less security implications