Skip to content

Conversation

@siavashs
Copy link
Contributor

@siavashs siavashs commented Sep 4, 2025

  • make dispatcher maintenance interval configurable

Related to #4540

@sysadmind
Copy link
Contributor

Can we leave the default to the original value? I'm not very familiar with the maintenance and don't know what other effects this could have. I would be inclined to merge with the original as the default so that we don't accidentally change the behavior for others in a negative way.

@siavashs siavashs force-pushed the dispatch-maintenance-interval-config branch from 943a3cf to 12399b2 Compare September 8, 2025 08:00
- make dispatcher maintenance interval configurable

Related to prometheus#4540

Signed-off-by: Siavash Safi <siavash@cloudflare.com>
@siavashs siavashs force-pushed the dispatch-maintenance-interval-config branch from 12399b2 to 1b221e3 Compare September 8, 2025 08:03
@siavashs
Copy link
Contributor Author

siavashs commented Sep 8, 2025

Made the default maintenance config 30s to match the previous static value.
Ci is as always falky!

@sysadmind sysadmind merged commit 117eb83 into prometheus:main Sep 13, 2025
15 of 17 checks passed
@siavashs siavashs deleted the dispatch-maintenance-interval-config branch September 14, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants