chore: improves logging around webhook dispatch failure #4511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CameronHall <cameron.hall@target.com>
|
It's not clear why the cli tests would have failed here. Debug logs show there was only one alert in the group. 😃 |
pehlicd
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
Tying the alerts that are being processed to failures reported under the dispatcher can be tricky, especially if there are many possible alerts that go through the same integration with different origins, etc.
There are a few different ways we could associate these like using the aggrGroup logger instead of the dispatcher logger, including the alerts list in the log directly. It felt cleanest to just attach the aggrGroup key to the log so that it can be associated with any logs that come from the aggrGroup logger. I'm open to alternatives though.
changes