feat: configurable provider channel buffer length #4364
+47
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siavashs
force-pushed
the
feat-alert-channel-buffer-length-config
branch
from
0d7fa59 to
ced40e2
Compare
This change makes the memory provider channel buffer length configurable. The previously hard-coded value of 200 is used as default. Bumping this value should result in better performance and less timeouts during sudden alert spikes, specially if the pipeline speed is affected by slow receivers. Signed-off-by: Siavash Safi <siavash@cloudflare.com>
siavashs
force-pushed
the
feat-alert-channel-buffer-length-config
branch
from
ced40e2 to
75bd989
Compare
|
Discussed here. I'm not against making this configurable, but I'm concerned that we don't understand enough about how and why this channel is becoming full and blocking. I've asked if we can get some profiles to better understand this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the memory provider channel buffer length configurable.
The previously hard-coded value of 200 is used as default.
Bumping this value should result in better performance and less timeouts during sudden alert spikes, specially if the pipeline speed is affected by slow receivers.