Pushover: Add monospace message formatting, add documentation for existing HTML styling #4362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobinson-grafana
approved these changes
May 3, 2025
config/notifiers.go
Outdated
| Expire duration `yaml:"expire,omitempty" json:"expire,omitempty"` | ||
| TTL duration `yaml:"ttl,omitempty" json:"ttl,omitempty"` | ||
| HTML bool `yaml:"html" json:"html,omitempty"` | ||
| Monospace bool `yaml:"monospace" json:"monospace,omitempty"` |
Collaborator
There was a problem hiding this comment.
It looks like we are missing omitempty on the yaml tag.
Contributor
Author
There was a problem hiding this comment.
Should the HTML yaml tag have an omitempty as well? It previously did not have it, so I kept this in line with the other bool. I added it to both now. :)
grobinson-grafana
requested changes
May 3, 2025
Collaborator
grobinson-grafana
left a comment
grobinson-grafana
left a comment
There was a problem hiding this comment.
A couple small changes, otherwise LGTM! 👍
Signed-off-by: Markus Cisler <hello@markuscisler.com>
Signed-off-by: Markus Cisler <hello@markuscisler.com>
grobinson-grafana
approved these changes
May 5, 2025
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all,
this is my first contibution to alertmanager. Please let me know if I missed something.
There are two changes in this PR, but hey seemed very related:
API documentation can be found here.