Skip to content

Conversation

@jan--f
Copy link
Contributor

@jan--f jan--f commented Jan 16, 2025

5m is an unfortunate value since its the same as the default group_interval. If only a single alert fires and a single notifier fails consistently the alert will never fire, since the rate[5m] will be 0 after less then the group_interval.

5m is an unfortunate value since its the same as the default
group_interval. If only a single alert fires and a single notifier
fails consistently the alert will never fire, since the rate[5m] will be
0 after less then the group_interval.

Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
Copy link

@marioferh marioferh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gotjosh gotjosh merged commit b2b8dd3 into prometheus:main Mar 11, 2025
12 checks passed
jan--f added a commit to jan--f/cluster-monitoring-operator that referenced this pull request May 7, 2025
This picks up prometheus/alertmanager#4206 so
we don't have to wait.

Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
jan--f added a commit to jan--f/cluster-monitoring-operator that referenced this pull request May 7, 2025
This picks up prometheus/alertmanager#4206 so
we don't have to wait.

Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants