Add silence logging option #4163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anarcat
force-pushed
the
add-silence-logging-option
branch
3 times, most recently
from
9cc6f24 to
95d90f5
Compare
Signed-off-by: m-masataka <m.mizukoshi.wakuwaku@gmail.com>
Signed-off-by: Antoine Beaupré <anarcat@debian.org>
anarcat
force-pushed
the
add-silence-logging-option
branch
2 times, most recently
from
b409d1e to
d3e8004
Compare
Signed-off-by: Antoine Beaupré <anarcat@debian.org>
anarcat
force-pushed
the
add-silence-logging-option
branch
from
d3e8004 to
47f1d8c
Compare
Signed-off-by: Antoine Beaupré <anarcat@debian.org>
anarcat
force-pushed
the
add-silence-logging-option
branch
from
47f1d8c to
7165770
Compare
Signed-off-by: Antoine Beaupré <anarcat@debian.org>
anarcat
force-pushed
the
add-silence-logging-option
branch
from
524ffdc to
c524d30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Past silences are really important to postmortem our alert management operations.
We need to get "when" and "what kind of" create/edit/delete silences.
So this PR added optional function that logging silence change.
Reroll of #2536 to address review item.