Skip to content

Conversation

@simonpasquier
Copy link
Member

Closes #3403

Closes prometheus#3403

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier simonpasquier requested a review from gotjosh August 4, 2023 12:29
Copy link
Member

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nice catch!

@simonpasquier
Copy link
Member Author

Note that I assumed that the TLS client configuration isn't required (though in most cases you probably want to provide the CA/cert/key). Feel free to correct me if I'm wrong :)

@simonpasquier simonpasquier merged commit 5626bd4 into prometheus:main Aug 7, 2023
@simonpasquier simonpasquier deleted the fix-panic branch August 7, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nil pointer derefernce when attempting to use the --cluster.tls-config arg

2 participants