add reason code to notifiers #3307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
qinxx108
force-pushed
the
4xx-error-for-notification-failure-receivers
branch
from
3bb4e4a to
b9b68d2
Compare
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
simonpasquier
approved these changes
Apr 7, 2023
Member
|
Thanks! |
hoperays
pushed a commit
to hoperays/alertmanager
that referenced
this pull request
Apr 23, 2023
* add reason code to notifiers Signed-off-by: Yijie Qin <qinyijie@amazon.com>
fgouteroux
pushed a commit
to fgouteroux/alertmanager
that referenced
this pull request
Apr 25, 2023
* add reason code to notifiers Signed-off-by: Yijie Qin <qinyijie@amazon.com> Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>
fgouteroux
pushed a commit
to fgouteroux/alertmanager
that referenced
this pull request
Apr 25, 2023
* add reason code to notifiers Signed-off-by: Yijie Qin <qinyijie@amazon.com> Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>
radek-ryckowski
pushed a commit
to goldmansachs/alertmanager
that referenced
this pull request
Nov 6, 2023
* add reason code to notifiers Signed-off-by: Yijie Qin <qinyijie@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this uses the new error with reason to determine based on status code what the reason is for the notifiers: