Capture receiver integration errors #3016
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an alerts traverses through the routing tree, there's a chance we fail to delivery the notification as we attempt to send it. This creates a problem where a user that has a failure in their template or their receiver integration (e.g. webhook) is unavailable has no visibility on this problem. This change, enhances the receiver API to include the last error, duration and time an alert went through the receiver. Signed-off-by: gotjosh <josue.abreu@gmail.com>
gotjosh
force-pushed
the
better-receivers-api
branch
from
8c2fc45 to
3b9c467
Compare
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Signed-off-by: gotjosh <josue.abreu@gmail.com>
gotjosh
force-pushed
the
better-receivers-api
branch
from
cf11843 to
b392f85
Compare
JohnnyQQQQ
reviewed
Aug 10, 2022
| integrations = append(integrations, &open_api_models.Integration{ | ||
| Name: &iname, | ||
| SendResolve: &sr, | ||
| LastNotify: notify.UTC().String(), |
There was a problem hiding this comment.
As it's still a draft ignore it if you already planned to do so: can we make sure that the date is in ISO 8601 format?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alerts traverses through the routing tree, there's a chance we fail to delivery the notification as we attempt to send it.
This creates a problem where a user that has a failure in their template or their receiver integration (e.g. webhook) is unavailable has no visibility on this problem.
This change, enhances the receiver API to include the last error, duration and time an alert went through the receiver.
This is heavily inspired by the targets Prometheus API which takes a similar approach.