-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix build of alertmanager without docker #2848
base: main
Are you sure you want to change the base?
chore: fix build of alertmanager without docker #2848
Conversation
Signed-off-by: Juraj Michalek <jmichalek@medallia.com>
b73bad1
to
ce2504c
Compare
Signed-off-by: Juraj Michalek <jmichalek@medallia.com>
Hi, @simonpasquier could you please take a look at this small change once you have some time? Thank you in advance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
oh wait! Would this work as you expect? When I tried locally, I get Lines 58 to 61 in ec2f5f5
|
That's interesting, yeah I what you are point out by for some reason it doesn't happen for us in our pipeline. |
Hi, so we build alertmanager from source because of some internal requirements. We do this inside docker as part of multi stage build. We also don't have docker in docker available.
We were using the
NO_DOCKER
env variable to make the build not use docker.However this does work on line 58, where
DOCKER_RUN_CURRENT_USER
is used insteadDOCKER_CMD
this one is not set to empty whenNO_DOCKER
env variable is set to true.This PR fixes that and makes the build work without docker available again.