Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify: Rename metrics variable name. #2828

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johncming
Copy link
Contributor

Keep metrics variable names consistent.

#2814

Signed-off-by: johncming <johncming@yahoo.com>
Copy link
Member

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noticed 2 small typos in the example config :) sorry, wrong PR

LGTM

@simonpasquier
Copy link
Member

@johncming have you enabled CircleCI on your fork? I'm not sure why the CI doesn't report anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants