Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuration.md #2702

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update configuration.md #2702

wants to merge 1 commit into from

Conversation

creganFL
Copy link

Clarified behaviour of default route
@simonpasquier @w0rm
Signed-off-by: Corey Regan cregan@freelancer.com

Clarified behaviour of default route
Signed-off-by: Corey Regan <cregan@freelancer.com>
@@ -130,9 +130,11 @@ must match all alerts (i.e. not have any configured matchers).
It then traverses the child nodes. If `continue` is set to false, it stops
after the first matching child. If `continue` is true on a matching node, the
alert will continue matching against subsequent siblings.
If an alert matches a child node with `continue` set to true, even if it is the
last sub-route, it will not trigger the default route.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This behavior is correct but it is the same as with any other routes. I think we should not add this wording, because this is what happens with any other route. We should not let readers believe that the default route is "special". (or do we have a bug?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree that the added sentence doesn't clarify the behavior.

@creganFL
Copy link
Author

creganFL commented Sep 14, 2021 via email

@stale stale bot added the stale label Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants