-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configuration.md #2702
base: main
Are you sure you want to change the base?
Update configuration.md #2702
Conversation
Clarified behaviour of default route Signed-off-by: Corey Regan <cregan@freelancer.com>
@@ -130,9 +130,11 @@ must match all alerts (i.e. not have any configured matchers). | |||
It then traverses the child nodes. If `continue` is set to false, it stops | |||
after the first matching child. If `continue` is true on a matching node, the | |||
alert will continue matching against subsequent siblings. | |||
If an alert matches a child node with `continue` set to true, even if it is the | |||
last sub-route, it will not trigger the default route. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This behavior is correct but it is the same as with any other routes. I think we should not add this wording, because this is what happens with any other route. We should not let readers believe that the default route is "special". (or do we have a bug?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i agree that the added sentence doesn't clarify the behavior.
I'm just trying to save somebody else hours of troubleshooting. In my new
role I am interacting with Prometheus/Alertmanager for the first time, and
it was not immediately obvious that the default route will never be
triggered if a sub-route matches. It makes sense after the fact, but in
that moment it did not.
…On Mon, Sep 13, 2021 at 3:57 PM Julien Pivotto ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/configuration.md
<#2702 (comment)>
:
> @@ -130,9 +130,11 @@ must match all alerts (i.e. not have any configured matchers).
It then traverses the child nodes. If `continue` is set to false, it stops
after the first matching child. If `continue` is true on a matching node, the
alert will continue matching against subsequent siblings.
+If an alert matches a child node with `continue` set to true, even if it is the
+last sub-route, it will not trigger the default route.
This behavior is correct but it is the same as with any other routes. I
think we should not add this wording, because this is what happens with any
other route. We should not let readers believe that the default route is
"special". (or do we have a bug?)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2702 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AU437W6MBBEIHFA5VBP7GPDUBZ6WTANCNFSM5D6TY4CA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Clarified behaviour of default route
@simonpasquier @w0rm
Signed-off-by: Corey Regan cregan@freelancer.com