config: fix JSON unmarshaling for HostPort#2134
Merged
simonpasquier merged 1 commit intoprometheus:release-0.20from Dec 11, 2019
Merged
config: fix JSON unmarshaling for HostPort#2134simonpasquier merged 1 commit intoprometheus:release-0.20from
simonpasquier merged 1 commit intoprometheus:release-0.20from
Conversation
client/client_test.go
Outdated
| ConfigYAML: "{}", | ||
| ConfigJSON: &config.Config{ | ||
| Global: &config.GlobalConfig{ | ||
| PagerdutyURL: &config.URL{u}, |
Contributor
There was a problem hiding this comment.
composites: github.com/prometheus/alertmanager/config.URL composite literal uses unkeyed fields (govet)
Contributor
There was a problem hiding this comment.
I would guess this means u needs to be given a key, but .. never seen this error before so :)
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
force-pushed
the
fix-json-unmarshal
branch
from
f77aa31 to
8525635
Compare
Member
Author
|
@stuartnelson3 friendly ping |
stuartnelson3
approved these changes
Dec 10, 2019
simonpasquier
added a commit
that referenced
this pull request
Dec 12, 2019
* Revert "slack: retry 429 errors (#2112)" (#2128) This reverts commit 26cc96a. Signed-off-by: Simon Pasquier <spasquie@redhat.com> * Revert "config: remove support for JSON marshaling (#2086)" (#2133) This reverts commit 918f08b. Signed-off-by: Simon Pasquier <spasquie@redhat.com> * config: fix JSON unmarshaling for HostPort (#2134) Signed-off-by: Simon Pasquier <spasquie@redhat.com> * Cut 0.20.0 (#2137) Signed-off-by: Simon Pasquier <spasquie@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2129