-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Import alertmanager docs #1062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import alertmanager docs #1062
Conversation
| - [Overview](overview.md) | ||
| - [Introduction](introduction.md) | ||
| - [Configuration](configuration.md) | ||
| - [Clients](clients.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clients should go last, that's a technical reference very very few people need.
docs/index.md
Outdated
| - [Introduction](introduction.md) | ||
| - [Configuration](configuration.md) | ||
| - [Clients](clients.md) | ||
| - [Notifications](notifications.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word Template should be in here
| @@ -0,0 +1,16 @@ | |||
| --- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the indexes not automatically generated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brian-brazil not sure about it. I didn't get the idea that the index.md on the promo repo was generated. Is there any reference about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look at them they're just the section title, with nothing else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grobie how did you generate the index.md on the prometheus doc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote the index.md by hand actually. My intent was to give users who read the docs locally a starting point. It was not meant to be just a list of the pages, but to include a small introduction as well. We can change that, but I guess a little explanation that the main documentation lives on a page online would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brian-brazil @grobie should I add a brief content to it, or just remove it for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd keep it as starting point. But I'm fine with either.
grobie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @josedonizetti! One last comment, then let's merge this!
docs/clients.md
Outdated
| --- | ||
| title: Clients | ||
| sort_rank: 6 | ||
| nav_icon: sliders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all the nav_icon settings please.
|
@grobie Done! Question, after this is merged how will be the process to update the documentation? |
|
We use https://www.netlify.com/ now to build and host the docs. They provide webhooks and I configured prometheus/prometheus to use the trigger that on every push. I'll do the same for alertmanager. I need to make some changes to the docs repo to support multiple versioned repo docs. Took some shortcuts on the way. |
|
@stuartnelson3 is cutting a new release for alertmanger, and there are some important changes that must be updated in the documentation (pagerduty, and opsgenie were upgraded to a new version of their APIs) #1089 Do we change the existing docs so users have it properly there, and later update it here, or the change you will do on the docs repo to support alertmanager is coming soon and we wait to update it only here? |
|
I'm almost done with the nanoc4 upgrade. I hope to have the changes ready tonight or latest Saturday night. |
|
@grobie Any updates on this? Anything I can help? |
|
@grobie ping |
|
ack
…On Thu, Dec 14, 2017 at 12:13 PM stuart nelson ***@***.***> wrote:
@grobie <https://github.com/grobie> ping
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1062 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAANaPbWjweXmFzck00V77jmz1lXPjH5ks5tAQLUgaJpZM4QMEYn>
.
|
|
@grobie Is this doc migration for alertmanager still happening? |
|
any way I can help progress this merge? |
|
Sorry for the delays. I've been busy with other projects recently. The
blocker is a upgrade and rewrite of the code in prometheus/docs. I'm 70%
done with that, but haven't had a chance to look into that again. I'll try
to reserve some time over the weekend and get that done, so that you can
update the docs here.
…On Fri, Jan 26, 2018 at 2:27 PM Tom Paine ***@***.***> wrote:
any way I can help progress this merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1062 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAANaKi-I9oHJqZsFyUsaDbr583S347yks5tOdK1gaJpZM4QMEYn>
.
|
|
@grobie status on this? |
|
@grobie Ping. Status? |
|
No progress. Depends on a change and rewrite of the docs infrastructure. I'll try to pick that up again during the next two weeks, but can't guarantee anything. |
|
@grobie Is this something that Luc (our new docs person) could help with, or are you too far into it? |
|
Superseeded by #2292 , and prometheus/docs#1657 |
|
Considering @roidelapluie work, I’m closing this PR. |
This is part of the ongoing work to versioned prometheus documentation.
prometheus/docs#857
@grobie