prometheus_text_format: Fix argument order for format_into/3 fun
#197
+32
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
the-mikedavis
force-pushed
the
md/fix-format-into
branch
from
29d7771 to
0e87dc1
Compare
The formatting function should take the state as the first argument and new data as the second. See `format/1` which passes in the trailing linefeed as the second argument. This doesn't make much difference when calling `format/1` because the swapped arguments only caused the metrics to be concatenated in reverse. But this fix is important for using `format_into/3` correctly, for example with `cowboy_req:stream_body/3`.
the-mikedavis
force-pushed
the
md/fix-format-into
branch
from
0e87dc1 to
8e55e6e
Compare
NelsonVides
approved these changes
Nov 22, 2025
Member
NelsonVides
left a comment
NelsonVides
left a comment
There was a problem hiding this comment.
Great to have a regression test for it too!
Member
Contributor
Author
|
Thanks for the super quick turnaround on this! I'm re-running my tests in RabbitMQ with 6.1.1. I can confirm that it works now 😅. And so far the comparison is still looking very good - I think the per-object metrics RabbitMQ end up using quite a few floats so the fast-path we added in #196 probably cuts down on temporary allocations by quite a bit. Edit: yep with these changes and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formatting function should take the state as the first argument and new data as the second. See
format/1which passes in the trailing linefeed as the second argument. This doesn't make much difference when callingformat/1because the swapped arguments only caused the metrics to be concatenated in reverse. But this fix is important for usingformat_into/3correctly, for example withcowboy_req:stream_body/3.