Fix broadcast address and enable unprivileged broadcast ping #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emin Umut Gercek <eumutgercek@gmail.com>
eugercek
force-pushed
the
fix-broadcast
branch
from
3f4f0a3
to
c650dad
Compare
With this commit "unprivileged" pings could be sent to broadcast addresses. Signed-off-by: Emin Umut Gercek <eumutgercek@gmail.com>
eugercek
force-pushed
the
fix-broadcast
branch
from
c650dad
to
d51e823
Compare
|
@SuperQ kindly ping. Implemented the feature we previously discussed. Second commit was a little necessity I found while implementing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In first commit #15 is fixed.
In second commit "unprivileged" broadcast ping feature is added.
Tests:
pingcommand doesn't support broadcast pinging I didn't work on that.Second commit may be useful for prometheus community, some may use it like: "create alarm when ping reply < 10 in 1 min" or so, but they may want to use non-root security principles.
EDIT: I have nearly zero knowledge on ipv6 but AFAIK it does not use broadcast addresses.
Screenshots
Linux:
Mac: