Skip to content

Add a collector for pg_buffercache. #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 143 additions & 0 deletions collector/pg_buffercache.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,143 @@
// Copyright 2023 The Prometheus Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package collector

import (
"context"
"database/sql"
"log/slog"

"github.com/blang/semver/v4"
"github.com/prometheus/client_golang/prometheus"
)

const buffercacheSubsystem = "buffercache"

func init() {
registerCollector(buffercacheSubsystem, defaultDisabled, NewBuffercacheCollector)
}

// BuffercacheCollector collects stats from pg_buffercache: https://www.postgresql.org/docs/current/pgbuffercache.html.
//
// It depends on the extension being loaded with
//
// create extension pg_buffercache;
//
// It does not take locks, see the PG docs above.
type BuffercacheCollector struct {
log *slog.Logger
}

func NewBuffercacheCollector(config collectorConfig) (Collector, error) {
return &BuffercacheCollector{
log: config.logger,
}, nil
}

var (
buffersUsedDesc = prometheus.NewDesc(
prometheus.BuildFQName(namespace, buffercacheSubsystem, "buffers_used"),
"Number of used shared buffers",
[]string{},
prometheus.Labels{},
)
buffersUnusedDesc = prometheus.NewDesc(
prometheus.BuildFQName(namespace, buffercacheSubsystem, "buffers_unused"),
"Number of unused shared buffers",
[]string{},
prometheus.Labels{},
)
buffersDirtyDesc = prometheus.NewDesc(
prometheus.BuildFQName(namespace, buffercacheSubsystem, "buffers_dirty"),
"Number of dirty shared buffers",
[]string{},
prometheus.Labels{},
)
buffersPinnedDesc = prometheus.NewDesc(
prometheus.BuildFQName(namespace, buffercacheSubsystem, "buffers_pinned"),
"Number of pinned shared buffers",
[]string{},
prometheus.Labels{},
)
usageCountAvgDesc = prometheus.NewDesc(
prometheus.BuildFQName(namespace, buffercacheSubsystem, "usagecount_avg"),
"Average usage count of used shared buffers",
[]string{},
prometheus.Labels{},
)

buffercacheQuery = `
SELECT
buffers_used,
buffers_unused,
buffers_dirty,
buffers_pinned,
usagecount_avg
FROM
pg_buffercache_summary()
`
)

func gaugeInt32(m sql.NullInt32, desc *prometheus.Desc, ch chan<- prometheus.Metric) {
mM := 0.0
if m.Valid {
mM = float64(m.Int32)
}
ch <- prometheus.MustNewConstMetric(desc, prometheus.GaugeValue, mM)
}

// Update implements Collector
// It is called by the Prometheus registry when collecting metrics.
func (c BuffercacheCollector) Update(ctx context.Context, instance *instance, ch chan<- prometheus.Metric) error {
// pg_buffercache_summary is only in v16, and we don't need support for earlier currently.
if !instance.version.GE(semver.MustParse("16.0.0")) {
return nil
}
db := instance.getDB()
rows, err := db.QueryContext(ctx, buffercacheQuery)
if err != nil {
return err
}
defer rows.Close()

var used, unused, dirty, pinned sql.NullInt32
var usagecountAvg sql.NullFloat64

for rows.Next() {
if err := rows.Scan(
&used,
&unused,
&dirty,
&pinned,
&usagecountAvg,
); err != nil {
return err
}

usagecountAvgMetric := 0.0
if usagecountAvg.Valid {
usagecountAvgMetric = usagecountAvg.Float64
}
ch <- prometheus.MustNewConstMetric(
usageCountAvgDesc,
prometheus.GaugeValue,
usagecountAvgMetric)
gaugeInt32(used, buffersUsedDesc, ch)
gaugeInt32(unused, buffersUnusedDesc, ch)
gaugeInt32(dirty, buffersDirtyDesc, ch)
gaugeInt32(pinned, buffersPinnedDesc, ch)
}

return rows.Err()
}
73 changes: 73 additions & 0 deletions collector/pg_buffercache_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
// Copyright 2023 The Prometheus Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package collector

import (
"context"
"testing"

"github.com/DATA-DOG/go-sqlmock"
"github.com/blang/semver/v4"
"github.com/prometheus/client_golang/prometheus"
dto "github.com/prometheus/client_model/go"
"github.com/smartystreets/goconvey/convey"
)

func TestBuffercacheCollector(t *testing.T) {
db, mock, err := sqlmock.New()
if err != nil {
t.Fatalf("Error opening a stub db connection: %s", err)
}
defer db.Close()

inst := &instance{db: db, version: semver.MustParse("16.0.0")}

columns := []string{
"buffers_used",
"buffers_unused",
"buffers_dirty",
"buffers_pinned",
"usagecount_avg"}

rows := sqlmock.NewRows(columns).AddRow(123, 456, 789, 234, 56.6778)

mock.ExpectQuery(sanitizeQuery(buffercacheQuery)).WillReturnRows(rows)

ch := make(chan prometheus.Metric)
go func() {
defer close(ch)
c := BuffercacheCollector{}

if err := c.Update(context.Background(), inst, ch); err != nil {
t.Errorf("Error calling PGStatStatementsCollector.Update: %s", err)
}
}()

expected := []MetricResult{
{labels: labelMap{}, metricType: dto.MetricType_GAUGE, value: 56.6778},
{labels: labelMap{}, metricType: dto.MetricType_GAUGE, value: 123},
{labels: labelMap{}, metricType: dto.MetricType_GAUGE, value: 456},
{labels: labelMap{}, metricType: dto.MetricType_GAUGE, value: 789},
{labels: labelMap{}, metricType: dto.MetricType_GAUGE, value: 234},
}

convey.Convey("Metrics comparison", t, func() {
for _, expect := range expected {
m := readMetric(<-ch)
convey.So(expect, convey.ShouldResemble, m)
}
})
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("there were unfulfilled exceptions: %s", err)
}
}