Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with configs/commands to be able to run the example on macOS #180

Merged
merged 2 commits into from
Nov 27, 2022

Conversation

turtletree
Copy link
Contributor

Updating a few configs/commands to be able to run the example on macOS

turtletree and others added 2 commits November 27, 2022 12:01
Updating a few configs/commands to be able to run the example on macOS

Signed-off-by: Vickie <vicky.liu.61@gmail.com>
Signed-off-by: rustyclock <rustyclock@protonmail.com>
@rustycl0ck
Copy link
Member

Thank you for the PR. I think it's better to keep the documentation concise and not too long. So I have kept only the minimal changes which just fix the docker network configuration. From docker documentation1, host.docker.internal should work on all platforms.

Footnotes

  1. https://docs.docker.com/desktop/networking/#use-cases-and-workarounds-for-all-platforms

@rustycl0ck rustycl0ck merged commit 35abd4a into prometheus-community:master Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants