Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Add Artifact Hub annotations for named links and operator search facet #95

Conversation

scottrigby
Copy link
Member

@scottrigby scottrigby commented Sep 14, 2020

What this PR does / why we need it:

Adds newly supported Artifact Hub annotations for named links and operator search facet.
See: artifacthub/hub#634

Special notes for your reviewer:

I also removed https://github.com/prometheus-operator/prometheus-operator as a source, since this is only one component of https://github.com/prometheus-operator/kube-prometheus and explained well there.

Chart maintainers: The link annotation could also be added to any of the other charts – in separate PRs – in order to enrich display in Artifact Hub. If anyone wants to take that on for the other charts 😉

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

…ator search facet

See: artifacthub/hub#634

Signed-off-by: Scott Rigby <scott@r6by.com>
charts/kube-prometheus-stack/Chart.yaml Outdated Show resolved Hide resolved
Signed-off-by: Scott Rigby <scott@r6by.com>
Copy link
Contributor

@gianrubio gianrubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@scottrigby scottrigby merged commit 5c8e31a into prometheus-community:main Sep 14, 2020
monotek pushed a commit to monotek/prometheus-helm-charts that referenced this pull request Oct 7, 2020
…and operator search facet (prometheus-community#95)

* Add newly supported Artifact Hub annotations for named links and operator search facet

See: artifacthub/hub#634

Signed-off-by: Scott Rigby <scott@r6by.com>

* Change artifacthub.io/operator from bool to quoted string

Signed-off-by: Scott Rigby <scott@r6by.com>
Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>
stamzid pushed a commit to Unstructured-IO/prometheus-community-helm-charts that referenced this pull request Mar 3, 2023
…and operator search facet (prometheus-community#95)

* Add newly supported Artifact Hub annotations for named links and operator search facet

See: artifacthub/hub#634

Signed-off-by: Scott Rigby <scott@r6by.com>

* Change artifacthub.io/operator from bool to quoted string

Signed-off-by: Scott Rigby <scott@r6by.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants