[prometheus-adapter] Remove colons from the ClusterRoleBinding resource name #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nickolay Kofanov <kofan.com@gmail.com>
kofan
requested review from
hectorj2f,
MattiasGees and
steven-sheehy
as code owners
monotek
approved these changes
Sep 14, 2020
steven-sheehy
approved these changes
Sep 14, 2020
2 tasks
monotek
pushed a commit
to monotek/prometheus-helm-charts
that referenced
this pull request
Oct 7, 2020
…ce (prometheus-community#94) Remove colons from the ClusterRoleBinding resource name to make the helm lint command pass for Helm 3.3+ Signed-off-by: Nickolay Kofanov <kofan.com@gmail.com> Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>
nf-npieros
pushed a commit
to nf-npieros/helm-charts
that referenced
this pull request
Jan 17, 2022
nf-npieros
pushed a commit
to nf-npieros/helm-charts
that referenced
this pull request
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove colons from the
ClusterRoleBindingresource name to make thehelm lintcommand pass for Helm 3.3+Which issue this PR fixes
Fixes #88
Checklist
[prometheus-couchdb-exporter])