[prometheus-kafka-exporter] Add kafka broker version #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evyatar Cohen <coevyatar@gmail.com>
Signed-off-by: Evyatar Cohen <coevyatar@gmail.com>
langecode
pushed a commit
to neticdk/helm-charts
that referenced
this pull request
Aug 12, 2021
…unity#896) * prometheus-kafka-exporter: add broker version Signed-off-by: Evyatar Cohen <coevyatar@gmail.com> * prometheus-kafka-exporter: fix trailing spaces Signed-off-by: Evyatar Cohen <coevyatar@gmail.com> Signed-off-by: Thor Anker Kvisgård Lange <tal@netic.dk>
QuentinBisson
pushed a commit
to giantswarm/prometheus-community-helm-charts-upstream
that referenced
this pull request
Oct 5, 2021
…unity#896) * prometheus-kafka-exporter: add broker version Signed-off-by: Evyatar Cohen <coevyatar@gmail.com> * prometheus-kafka-exporter: fix trailing spaces Signed-off-by: Evyatar Cohen <coevyatar@gmail.com> Signed-off-by: QuentinBisson <quentin@giantswarm.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Evyatar Cohen coevyatar@gmail.com
What this PR does / why we need it:
This PR adds the option to specify Kafka broker version to
kafka_exporter. While trying to installkafka_exportervia the chart, an error of connection failure is returned and looking under Kafka's logs an error regarding api key is returned.Changing the broker version manually worked and this change will help those who encounter similar issue.
Which issue this PR fixes
No issue in issues.
Special notes for your reviewer:
Checklist
[prometheus-couchdb-exporter])