Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-statsd-exporter] Fix statsd service monitor config #732

Merged

Conversation

duncaan
Copy link
Contributor

@duncaan duncaan commented Mar 5, 2021

Addresses #649
Signed-off-by: Duncan Schulze duncan.schulze@cloudcheckr.com

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@duncaan duncaan force-pushed the fix-statsd-servicemonitor branch from 230d7c9 to bf001c4 Compare March 5, 2021 17:15
@duncaan duncaan changed the title Fix statsd service monitor config [prometheus-statsd-exporter] Fix statsd service monitor config Mar 5, 2021
@duncaan duncaan force-pushed the fix-statsd-servicemonitor branch from bf001c4 to f24df6b Compare March 5, 2021 17:32
Addresses prometheus-community#649
Signed-off-by: Duncan Schulze <duncan.schulze@cloudcheckr.com>
@duncaan duncaan force-pushed the fix-statsd-servicemonitor branch from f24df6b to 6b7d2d2 Compare March 5, 2021 17:52
@duncaan
Copy link
Contributor Author

duncaan commented Mar 5, 2021

@scDisorder - are you able to review this?

Copy link
Contributor

@scDisorder scDisorder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, what a simple mistake, thx

@scDisorder
Copy link
Contributor

woah, just saw the issue, thank you a lot again

@duncaan
Copy link
Contributor Author

duncaan commented Mar 9, 2021

@scottrigby @monotek - are either of you able to approve/merge this as the codeowner has approved it? Thanks in advance!

@monotek monotek merged commit 8318ce1 into prometheus-community:main Mar 10, 2021
@duncaan duncaan deleted the fix-statsd-servicemonitor branch April 20, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prometheus-statsd-exporter] ServiceMonitor matchLabels set incorrectly
3 participants