[kube-prometheus-stack] Add config.templates #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without config.templates defined any templates defined in templateFiles will not be loaded. The default location and suffix are in line with the examples in the alertmanager and kube-prometheus-stack docs. Signed-off-by: Kevin Maris <kevin@kmaris.net>
kmaris
requested review from
bismarck,
gianrubio,
gkarthiks,
scottrigby,
vsliouniaev and
Xtigyro
as code owners
Signed-off-by: Kevin Maris <kevin@kmaris.net>
|
I didn't exactly know what to bump it too either, thanks :) Signed-off! |
stamzid
pushed a commit
to Unstructured-IO/prometheus-community-helm-charts
that referenced
this pull request
Mar 3, 2023
* [kube-prometheus-stack] Add config.templates Without config.templates defined any templates defined in templateFiles will not be loaded. The default location and suffix are in line with the examples in the alertmanager and kube-prometheus-stack docs. Signed-off-by: Kevin Maris <kevin@kmaris.net> * Update Chart.yaml Signed-off-by: Kevin Maris <kevin@kmaris.net> Co-authored-by: André Bauer <monotek@users.noreply.github.com> Co-authored-by: Bismarck Paliz <bismarck.paliz@jet.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without config.templates defined any templates defined in templateFiles
will not be loaded. The default location and suffix are in line with the
examples in the alertmanager and kube-prometheus-stack docs.
Signed-off-by: Kevin Maris kevin@kmaris.net
What this PR does / why we need it:
Without config.templates set templateFiles will not be loaded in alertmanager.
Which issue this PR fixes
Special notes for your reviewer:
I was unsure of wording for the templateFiles doc section. Happy to update if you prefer something else.
Checklist
[prometheus-couchdb-exporter])