kube-prometheus-stack bugfix wrong line break and add https redirect route #5276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RenePinnow
requested review from
GMartinez-Sisti,
QuentinBisson,
Xtigyro,
andrewgkew,
gianrubio,
gkarthiks,
jkroepke and
scottrigby
as code owners
jkroepke
reviewed
Feb 5, 2025
jkroepke
reviewed
Feb 5, 2025
jkroepke
reviewed
Feb 5, 2025
|
@jkroepke |
|
@andrewgkew @gianrubio @gkarthiks @GMartinez-Sisti @jkroepke @scottrigby @Xtigyro @QuentinBisson |
jkroepke
reviewed
Feb 12, 2025
added 3 commits
February 14, 2025 14:15
…ps redirect route Signed-off-by: Pinnow René <rene.pinnow.bu@gmail.com>
Signed-off-by: Pinnow René <rene.pinnow.bu@gmail.com>
Signed-off-by: Pinnow René <rene.pinnow.bu@gmail.com>
Signed-off-by: Pinnow René <rene.pinnow.bu@gmail.com>
jkroepke
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Bugfixing an issue by creating multiple routes for alertmanager, prometheus and thanosruler. In this case the linebreak does not work and the outcome is not a valid resource.
Adding new feature to create a route for https redirect see also https://gateway-api.sigs.k8s.io/guides/http-redirect-rewrite/#http-to-https-redirects
Which issue this PR fixes
No open issue found that points to this bug and feature
Special notes for your reviewer
@andrewgkew @gianrubio @gkarthiks @GMartinez-Sisti @jkroepke @scottrigby @Xtigyro @QuentinBisson
Checklist
[prometheus-couchdb-exporter])