[kube-prometheus-stack] Disable kube-state-metrics service scraping by default #5260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chart is set up to install the service monitor for kube-state-metrics so it's easy to duplicate metrics if scraping is not disabled. Signed-off-by: gdsmith <george@mukuru.com>
gdsmith
requested review from
GMartinez-Sisti,
QuentinBisson,
Xtigyro,
andrewgkew,
gianrubio,
gkarthiks,
jkroepke and
scottrigby
as code owners
jkroepke
requested changes
Jan 31, 2025
Signed-off-by: gdsmith <george@mukuru.com>
jkroepke
approved these changes
Jan 31, 2025
|
Thanks |
|
FYI, this broke our ksm, we did use the default config but the removal of that caused while the target appeared in prometheus it was empty |
|
@KyriosGN0 the servicemonitor approach wont work with ksm? |
|
@jkroepke nvm, seems like a false alarm, some dev cluster had nasty leftovers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Chart is set up to install the service monitor for kube-state-metrics so it's easy to duplicate metrics if scraping is not disabled.
Which issue this PR fixes
Special notes for your reviewer
@andrewgkew, @gianrubio, @gkarthiks, @GMartinez-Sisti, @jkroepke, @scottrigby, @Xtigyro, @QuentinBisson
Not sure about what level of version bump this should be, just went with patch release, happy to take advisement on this though. I know it's fixing a closed issue, but it takes a bit of knowledge and experience to track down why this happens and fix it so felt it was worth a PR.
Checklist
[prometheus-couchdb-exporter])