[prometheus] add .Capabilities.APIVersions for IngressClass fixes #507 #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
gianrubio,
monotek,
naseemkullah,
Xtigyro and
zanhsieh
as code owners
added 4 commits
December 20, 2020 18:22
Signed-off-by: Daniel Haas <dhaas@kube1.mekoto.us>
Signed-off-by: Daniel Haas <dhaas@kube1.mekoto.us>
Signed-off-by: Daniel Haas <dhaas@kube1.mekoto.us>
Signed-off-by: Daniel Haas <dhaas@kube1.mekoto.us>
zanhsieh
approved these changes
Dec 21, 2020
monotek
approved these changes
Dec 21, 2020
survivant
pushed a commit
to survivant/helm-charts
that referenced
this pull request
Dec 22, 2020
…metheus-community#507 (prometheus-community#508) * added support for ingressClassName Signed-off-by: Daniel Haas <dhaas@kube1.mekoto.us> * added support for ingressClassName Signed-off-by: Daniel Haas <dhaas@kube1.mekoto.us> * bump chart version Signed-off-by: Daniel Haas <dhaas@kube1.mekoto.us> * fixed incorrect values path Signed-off-by: Daniel Haas <dhaas@kube1.mekoto.us> Signed-off-by: Sebastien Dionne <Sebastien.Dionne@bidgroup.ca>
torstenwalter
added a commit
to torstenwalter/prometheus-helm-charts
that referenced
this pull request
Dec 29, 2020
``` $ git log --oneline charts/prometheus 034bbda (origin/main, origin/HEAD) Added absent allowedHostPath to psp for node-exporter (prometheus-community#470) e4d7a0c (tag: prometheus-13.0.1) [prometheus] add .Capabilities.APIVersions for IngressClass fixes prometheus-community#507 (prometheus-community#508) ``` Therefor chart releasing failed for the second time as a chart with that version ws already released. This PR just bumps the version to create a new release with that change. Signed-off-by: Torsten Walter <mail@torstenwalter.de>
torstenwalter
added a commit
to torstenwalter/prometheus-helm-charts
that referenced
this pull request
Dec 29, 2020
PR prometheus-community#570 and prometheus-community#470 used same chart version 13.0.1 ``` $ git log --oneline charts/prometheus 034bbda (origin/main, origin/HEAD) Added absent allowedHostPath to psp for node-exporter (prometheus-community#470) e4d7a0c (tag: prometheus-13.0.1) [prometheus] add .Capabilities.APIVersions for IngressClass fixes prometheus-community#507 (prometheus-community#508) ``` Therefor chart releasing failed for the second time as a chart with that version ws already released. This PR just bumps the version to create a new release with that change. Signed-off-by: Torsten Walter <mail@torstenwalter.de>
torstenwalter
added a commit
to torstenwalter/prometheus-helm-charts
that referenced
this pull request
Dec 29, 2020
PR prometheus-community#508 and prometheus-community#470 used same chart version 13.0.1 ``` $ git log --oneline charts/prometheus 034bbda (origin/main, origin/HEAD) Added absent allowedHostPath to psp for node-exporter (prometheus-community#470) e4d7a0c (tag: prometheus-13.0.1) [prometheus] add .Capabilities.APIVersions for IngressClass fixes prometheus-community#507 (prometheus-community#508) ``` Therefor chart releasing failed for the second time as a chart with that version ws already released. This PR just bumps the version to create a new release with that change. Signed-off-by: Torsten Walter <mail@torstenwalter.de>
torstenwalter
added a commit
to torstenwalter/prometheus-helm-charts
that referenced
this pull request
Dec 29, 2020
PR prometheus-community#508 and prometheus-community#470 used same chart version 13.0.1 ``` $ git log --oneline charts/prometheus 034bbda (origin/main, origin/HEAD) Added absent allowedHostPath to psp for node-exporter (prometheus-community#470) e4d7a0c (tag: prometheus-13.0.1) [prometheus] add .Capabilities.APIVersions for IngressClass fixes prometheus-community#507 (prometheus-community#508) ``` Therefor chart releasing failed for the second time as a chart with that version was already released. This PR just bumps the version to create a new release with that change. Signed-off-by: Torsten Walter <mail@torstenwalter.de>
3 tasks
monotek
pushed a commit
that referenced
this pull request
Dec 29, 2020
PR #508 and #470 used same chart version 13.0.1 ``` $ git log --oneline charts/prometheus 034bbda (origin/main, origin/HEAD) Added absent allowedHostPath to psp for node-exporter (#470) e4d7a0c (tag: prometheus-13.0.1) [prometheus] add .Capabilities.APIVersions for IngressClass fixes #507 (#508) ``` Therefor chart releasing failed for the second time as a chart with that version was already released. This PR just bumps the version to create a new release with that change. Signed-off-by: Torsten Walter <mail@torstenwalter.de>
zanhsieh
pushed a commit
that referenced
this pull request
Jan 4, 2021
#508) * added support for ingressClassName Signed-off-by: Daniel Haas <dhaas@kube1.mekoto.us> * added support for ingressClassName Signed-off-by: Daniel Haas <dhaas@kube1.mekoto.us> * bump chart version Signed-off-by: Daniel Haas <dhaas@kube1.mekoto.us> * fixed incorrect values path Signed-off-by: Daniel Haas <dhaas@kube1.mekoto.us>
zanhsieh
pushed a commit
that referenced
this pull request
Jan 4, 2021
PR #508 and #470 used same chart version 13.0.1 ``` $ git log --oneline charts/prometheus 034bbda (origin/main, origin/HEAD) Added absent allowedHostPath to psp for node-exporter (#470) e4d7a0c (tag: prometheus-13.0.1) [prometheus] add .Capabilities.APIVersions for IngressClass fixes #507 (#508) ``` Therefor chart releasing failed for the second time as a chart with that version was already released. This PR just bumps the version to create a new release with that change. Signed-off-by: Torsten Walter <mail@torstenwalter.de>
chris-vest
pushed a commit
to chris-vest/helm-charts
that referenced
this pull request
Jan 14, 2021
…metheus-community#507 (prometheus-community#508) * added support for ingressClassName Signed-off-by: Daniel Haas <dhaas@kube1.mekoto.us> * added support for ingressClassName Signed-off-by: Daniel Haas <dhaas@kube1.mekoto.us> * bump chart version Signed-off-by: Daniel Haas <dhaas@kube1.mekoto.us> * fixed incorrect values path Signed-off-by: Daniel Haas <dhaas@kube1.mekoto.us> Signed-off-by: chris-vest <intellivision@pm.me>
chris-vest
pushed a commit
to chris-vest/helm-charts
that referenced
this pull request
Jan 14, 2021
PR prometheus-community#508 and prometheus-community#470 used same chart version 13.0.1 ``` $ git log --oneline charts/prometheus 034bbda (origin/main, origin/HEAD) Added absent allowedHostPath to psp for node-exporter (prometheus-community#470) e4d7a0c (tag: prometheus-13.0.1) [prometheus] add .Capabilities.APIVersions for IngressClass fixes prometheus-community#507 (prometheus-community#508) ``` Therefor chart releasing failed for the second time as a chart with that version was already released. This PR just bumps the version to create a new release with that change. Signed-off-by: Torsten Walter <mail@torstenwalter.de> Signed-off-by: chris-vest <intellivision@pm.me>
This was referenced Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds support for ingressClassName for kubernetes >1.18.
Which issue this PR fixes
Fixes #507
Special notes for your reviewer:
Checklist
[prometheus-couchdb-exporter])