[kube-prometheus-stack] Add grpc thanos port to prometheus service #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codezomb
requested review from
bismarck,
gianrubio,
gkarthiks,
scottrigby,
vsliouniaev and
Xtigyro
as code owners
Signed-off-by: Mike Kelley <mike@codezombie.org>
Signed-off-by: Mike Kelley <mike@codezombie.org>
codezomb
changed the title
|
This fix would be quite helpful. Anything we can do to get it merged? |
gkarthiks
previously approved these changes
Jan 15, 2021
|
@PSjoe seems the PR is still a WIP. |
|
@monotek, updated. |
monotek
approved these changes
Jan 19, 2021
|
Thanks! |
stamzid
pushed a commit
to Unstructured-IO/prometheus-community-helm-charts
that referenced
this pull request
Mar 3, 2023
…rometheus-community#504) * Add grpc thanos port to prometheus service Signed-off-by: Mike Kelley <mike@codezombie.org> * bump version Signed-off-by: Mike Kelley <mike@codezombie.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds grpc thanos port to prometheus service. The thanos ingress was pointing to a non-existent port.
Which issue this PR fixes
Checklist
[prometheus-couchdb-exporter])