Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-node-exporter] Fix very slow GKE cluster upgrades #485

Merged
merged 3 commits into from
Feb 1, 2021
Merged

[prometheus-node-exporter] Fix very slow GKE cluster upgrades #485

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfb55cf
[prometheus-node-exporter] Fix very slow GKE cluster upgrades
gw0 Dec 11, 2020
f8daa32
[prometheus-node-exporter] Bump version
gw0 Dec 11, 2020
e6e4a27
Merge branch 'main' into gw0/fix-slow-gke-cluster-upgrades
vsliouniaev Jan 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[prometheus-node-exporter] Fix very slow GKE cluster upgrades 
Signed-off-by: gw0 <gw.2020@ena.one>
  • Loading branch information
@gw0
gw0 committed Dec 11, 2020
commit cfb55cfd4cd428ae96f0111097f29888d08915c3
4 changes: 3 additions & 1 deletion charts/prometheus-node-exporter/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,9 @@ affinity: {}
# - target-host-name

# Annotations to be added to node exporter pods
podAnnotations: {}
podAnnotations:
# Fix for very slow GKE cluster upgrades
cluster-autoscaler.kubernetes.io/safe-to-evict: "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this PR exists. Are you having trouble passing this map to the existing annotations helm value? It appears you can already do this.

Copy link
Contributor Author

@gw0 gw0 Jan 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of this PR is to provide a new default setting that fixes an issue that all GKE users are experiencing (most without knowing why). It is in values.yaml to allow everyone to override it if needed.


# Extra labels to be added to node exporter pods
podLabels: {}
Expand Down