Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Correct provisioning for the --thanos-ruler-instance-namespaces prometheus-operator argument #386

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

vladarts
Copy link
Contributor

… prometheus-operator

Signed-off-by: xxxbobrxxx xxxbobrxxx@gmail.com

What this PR does / why we need it: Previous version passed --thanos-instance-namespaces argument which is not present in the actual prometheus-operator version

Special notes for your reviewer: no

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

… prometheus-operator

Signed-off-by: xxxbobrxxx <xxxbobrxxx@gmail.com>
Copy link
Contributor

@vsliouniaev vsliouniaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this could not have worked before, so I don't see an issue with the rename in values.yaml

@vsliouniaev vsliouniaev merged commit 1ac9b7e into prometheus-community:main Nov 18, 2020
stamzid pushed a commit to Unstructured-IO/prometheus-community-helm-charts that referenced this pull request Mar 3, 2023
… prometheus-operator (prometheus-community#386)

Signed-off-by: xxxbobrxxx <xxxbobrxxx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants