[prometheus-blackbox-exporter] add detail comment to the option allowMonitoringNamespace in values.yaml #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verdel
requested review from
desaintmartin,
gianrubio,
monotek and
rsotnychenko
as code owners
…MonitoringNamespace in values.yaml Signed-off-by: Vadim Aleksandrov <valeksandrov@me.com>
|
Thanks! Indeed it was not clear and error-prone. |
desaintmartin
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The namespaceSelector applies to labels on a Namespace, not fields on a Namespace.
There is a discussion about this in the kubernetes repository - kubernetes/kubernetes#88253
I described this in more detail in the comment on the option
allowMonitoringNamespaceinvalues.yamlWhich issue this PR fixes