Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charts/kube-prometheus-stack: fix typos #318

Merged

Conversation

invidian
Copy link
Contributor

@invidian invidian commented Nov 6, 2020

Splitted #313 per chart as requested.

Signed-off-by: Mateusz Gozdek mgozdekof@gmail.com

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@invidian invidian force-pushed the fix-typos-kube-prometheus-stack branch from a6c73ac to 647bef1 Compare November 6, 2020 14:40
Copy link
Member

@monotek monotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please raise chart version to 11.0.4

Splitted prometheus-community#313 per chart as requested.

Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
@invidian invidian force-pushed the fix-typos-kube-prometheus-stack branch from 647bef1 to 06cc5cf Compare November 6, 2020 14:47
@invidian invidian requested a review from monotek November 6, 2020 14:47
@invidian
Copy link
Contributor Author

invidian commented Nov 6, 2020

please raise chart version to 11.0.4

Done 👍

monotek
monotek previously approved these changes Nov 6, 2020
@invidian invidian requested a review from bismarck November 6, 2020 16:30
gkarthiks
gkarthiks previously approved these changes Nov 7, 2020
@bismarck bismarck dismissed stale reviews from gkarthiks and monotek via 92a6f73 November 9, 2020 17:39
Copy link
Contributor

@bismarck bismarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bismarck bismarck merged commit 0ce03b5 into prometheus-community:main Nov 9, 2020
@invidian invidian deleted the fix-typos-kube-prometheus-stack branch November 9, 2020 18:51
stamzid pushed a commit to Unstructured-IO/prometheus-community-helm-charts that referenced this pull request Mar 3, 2023
Splitted prometheus-community#313 per chart as requested.

Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>

Co-authored-by: Bismarck Paliz <bismarck.paliz@jet.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants