Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jiralert] Setup chart #2591

Merged
merged 1 commit into from
Oct 30, 2022
Merged

Conversation

jkroepke
Copy link
Member

Signed-off-by: Jan-Otto Kröpke jok@cloudeteer.de

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@jkroepke jkroepke requested a review from a team as a code owner October 20, 2022 09:15
@jkroepke
Copy link
Member Author

Test chart job failes, because no default receivers are defined. This results into a CrashLoopBackOff. Should I add some non working default receivers to get the lint job working?

@monotek
Copy link
Member

monotek commented Oct 22, 2022

Test chart job failes, because no default receivers are defined. This results into a CrashLoopBackOff. Should I add some non working default receivers to get the lint job working?

Yes, chart should be able to start the container with the default config. Maybe also some test values in the ci directory would do the trick.

@jkroepke jkroepke force-pushed the jiralert branch 4 times, most recently from bf9e58f to b641e1c Compare October 27, 2022 12:53
charts/jiralert/values.yaml Outdated Show resolved Hide resolved
charts/jiralert/templates/secret.yaml Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
charts/jiralert/Chart.yaml Show resolved Hide resolved
charts/jiralert/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/jiralert/templates/ingress.yaml Outdated Show resolved Hide resolved
charts/jiralert/templates/ingress.yaml Outdated Show resolved Hide resolved
charts/jiralert/templates/deployment.yaml Show resolved Hide resolved
charts/jiralert/templates/ingress.yaml Outdated Show resolved Hide resolved
charts/jiralert/values.yaml Outdated Show resolved Hide resolved
@jkroepke jkroepke force-pushed the jiralert branch 2 times, most recently from da3d064 to 63a6d6e Compare October 29, 2022 16:29
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@monotek monotek merged commit b9d929d into prometheus-community:main Oct 30, 2022
@jkroepke jkroepke deleted the jiralert branch October 31, 2022 00:22
Matiasmct pushed a commit to giffgaff/prometheus-charts-backup that referenced this pull request May 16, 2023
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do we have helm chart for jiralert?
3 participants