Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Replacing hyperkube image with kubectl image from bitnami #160

Merged
merged 2 commits into from
Oct 5, 2020

Conversation

bismarck
Copy link
Contributor

What this PR does / why we need it:

The hypercube image has been deprecated and will no longer be built. Replacing with the kubectl image from the bitnami repository

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Copy link
Member

@gkarthiks gkarthiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bismarck bismarck requested a review from gkarthiks October 2, 2020 15:05
@bismarck
Copy link
Contributor Author

bismarck commented Oct 2, 2020

@gkarthiks Could you approve and merge this in? Thanks!

@gkarthiks
Copy link
Member

sorry @bismarck, was away for a little while. Could you please bump the chart version to 9.4.7

Bismarck Paliz added 2 commits October 4, 2020 21:50
Signed-off-by: Bismarck Paliz <bismarck.paliz@jet.com>
Signed-off-by: Bismarck Paliz <bismarck.paliz@jet.com>
@bismarck
Copy link
Contributor Author

bismarck commented Oct 5, 2020

@gkarthiks I bumped the version.

@gkarthiks gkarthiks merged commit 89b1338 into prometheus-community:main Oct 5, 2020
monotek pushed a commit to monotek/prometheus-helm-charts that referenced this pull request Oct 7, 2020
…from bitnami (prometheus-community#160)

* Replacing hyperkube image with kubectl image from bitnami

Signed-off-by: Bismarck Paliz <bismarck.paliz@jet.com>

* Bumping version

Signed-off-by: Bismarck Paliz <bismarck.paliz@jet.com>
Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>
stamzid pushed a commit to Unstructured-IO/prometheus-community-helm-charts that referenced this pull request Mar 3, 2023
…from bitnami (prometheus-community#160)

* Replacing hyperkube image with kubectl image from bitnami

Signed-off-by: Bismarck Paliz <bismarck.paliz@jet.com>

* Bumping version

Signed-off-by: Bismarck Paliz <bismarck.paliz@jet.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prometheus-kube-stack] Still using Hyperkube
2 participants