prometheus: align relabelling convention with prometheus example #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: paulfantom <pawel@krupa.net.pl>
paulfantom
requested review from
gianrubio,
monotek,
naseemkullah,
Xtigyro and
zanhsieh
as code owners
monotek
requested changes
Nov 22, 2021
Signed-off-by: paulfantom <pawel@krupa.net.pl>
paulfantom
force-pushed
the
align-on-convention
branch
from
dee5797 to
6701509
Compare
Sure, already done. I updated all tags in values.yaml and bumped kube-state-metrics chart to v4 |
monotek
requested changes
Nov 23, 2021
There was a problem hiding this comment.
Please also add some info whats changed to the upgrading section of the readme: https://github.com/prometheus-community/helm-charts/blob/main/charts/prometheus/README.md#upgrading-chart
Signed-off-by: André Bauer <andre.bauer@staffbase.com>
monotek
force-pushed
the
align-on-convention
branch
from
fe06e8a to
3f968c4
Compare
monotek
previously approved these changes
Nov 27, 2021
Signed-off-by: André Bauer <andre.bauer@staffbase.com>
Signed-off-by: André Bauer <andre.bauer@staffbase.com>
|
@paulfantom I think it causes a regression bug #1548 |
aslafy-z
pushed a commit
to aslafy-z/helm-charts-2
that referenced
this pull request
Jan 24, 2022
…metheus-community#1520) * charts/prometheus: align relabelling convention with prometheus example Signed-off-by: paulfantom <pawel@krupa.net.pl> * charts/prometheus: update component versions to latest available Signed-off-by: paulfantom <pawel@krupa.net.pl> * added update info to readme Signed-off-by: André Bauer <andre.bauer@staffbase.com> * fix whitespace Signed-off-by: André Bauer <andre.bauer@staffbase.com> * fix cli command Signed-off-by: André Bauer <andre.bauer@staffbase.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com> Co-authored-by: André Bauer <andre.bauer@staffbase.com> Signed-off-by: GitHub <noreply@github.com>
3 tasks
zanhsieh
pushed a commit
that referenced
this pull request
Apr 7, 2022
This PR aims to address both #1548 and #1613. Changes made in #1520, which ensure alignment with Prometheus labeling conventions, have caused issues in cases where a resource is publishing metrics about another resource. One example is kube-state-metrics, which publishes metrics about other kubernetes resources with labels respecting the convention, however prometheus overwrites these with labels that are true about kube-state-metrics. This PR fixes that. Signed-off-by: Endre Kadas <ekadas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR aligns metric relabelings with the convention used in prometheus (prometheus/prometheus#9832), prometheus-operator, kube-state-metrics, kubernetes instrumentation, and monitoring mixins.
This is a breaking PR as following metric labels changed:
kubernetes_namespace->namespacekubernetes_name->servicekubernetes_pod_name->podkubernetes_node->nodeI bumped chart major version to note the breaking change.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[prometheus-couchdb-exporter])