[kube-prometheus-stack] style(grafana): fix typo #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jai
requested review from
bismarck,
gianrubio,
gkarthiks,
scottrigby,
vsliouniaev and
Xtigyro
as code owners
jai
changed the title
monotek
requested changes
Sep 28, 2020
There was a problem hiding this comment.
You have to raise the chart version too.
An please sign your commits to get the DCO check passed: https://github.com/prometheus-community/helm-charts/pull/150/checks?check_run_id=1175570543
Signed-off-by: Jai Govindani <jai@honestbank.com>
Signed-off-by: Jai Govindani <jai@honestbank.com>
|
@monotek thanks, and done! |
gkarthiks
previously approved these changes
Oct 2, 2020
monotek
approved these changes
Oct 5, 2020
gkarthiks
approved these changes
Oct 5, 2020
monotek
pushed a commit
to monotek/prometheus-helm-charts
that referenced
this pull request
Oct 7, 2020
…y#150) * style(grafana): fix typo Signed-off-by: Jai Govindani <jai@honestbank.com> * chore(kube-prometheus-stack): bump chart version Signed-off-by: Jai Govindani <jai@honestbank.com> Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>
stamzid
pushed a commit
to Unstructured-IO/prometheus-community-helm-charts
that referenced
this pull request
Mar 3, 2023
…y#150) * style(grafana): fix typo Signed-off-by: Jai Govindani <jai@honestbank.com> * chore(kube-prometheus-stack): bump chart version Signed-off-by: Jai Govindani <jai@honestbank.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Fixes capitalization errors in some Grafana dashboards
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Checklist
[prometheus-couchdb-exporter])Signed-off-by: Jai Govindani jai@honestbank.com