Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Sync dashboards and rules #1075

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

mrueg
Copy link
Member

@mrueg mrueg commented Jun 15, 2021

What this PR does / why we need it:

prometheus-operator/kube-prometheus' default branch switched to main, so we missed a lot of updates.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@mrueg mrueg force-pushed the sync-db-rules branch 5 times, most recently from d19cb9e to dc6ddef Compare June 15, 2021 09:17
@Xtigyro Xtigyro self-assigned this Jun 15, 2021
Copy link
Member

@Xtigyro Xtigyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, @mrueg! 🥇

Could you please bump the minor chart version (not the patch version)?

prometheus-operator/kube-prometheus' default branch switched to main, so
we missed some updates.

Also we did not update the alertmanager, node-exporter and prometheus-operator rulesets,
which is fixed now as well.

Signed-off-by: Manuel Rüger <manuel@rueg.eu>
@mrueg
Copy link
Member Author

mrueg commented Jun 15, 2021

Bumped minor.
This hopefully fixes #1054

Copy link
Member

@Xtigyro Xtigyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thank you!

@Xtigyro Xtigyro merged commit 5477284 into prometheus-community:main Jun 15, 2021
langecode pushed a commit to neticdk/helm-charts that referenced this pull request Aug 12, 2021
…ty#1075)

prometheus-operator/kube-prometheus' default branch switched to main, so
we missed some updates.

Also we did not update the alertmanager, node-exporter and prometheus-operator rulesets,
which is fixed now as well.

Signed-off-by: Manuel Rüger <manuel@rueg.eu>
Signed-off-by: Thor Anker Kvisgård Lange <tal@netic.dk>
QuentinBisson pushed a commit to giantswarm/prometheus-community-helm-charts-upstream that referenced this pull request Oct 5, 2021
…ty#1075)

prometheus-operator/kube-prometheus' default branch switched to main, so
we missed some updates.

Also we did not update the alertmanager, node-exporter and prometheus-operator rulesets,
which is fixed now as well.

Signed-off-by: Manuel Rüger <manuel@rueg.eu>
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
stamzid pushed a commit to Unstructured-IO/prometheus-community-helm-charts that referenced this pull request Mar 3, 2023
…ty#1075)

prometheus-operator/kube-prometheus' default branch switched to main, so
we missed some updates.

Also we did not update the alertmanager, node-exporter and prometheus-operator rulesets,
which is fixed now as well.

Signed-off-by: Manuel Rüger <manuel@rueg.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants